search

digitalocean / digitalocean-cloud-controller-manager

Kubernetes cloud-controller-manager for DigitalOcean (beta)
Apache License 2.0
524 stars 148 forks source link

`service.beta.kubernetes.io/do-loadbalancer-hostname`: Use `nip.io` for easier setup? #756

Open simonhammes opened 2 weeks ago

simonhammes commented 2 weeks ago

Hi,

would it be possible to automatically set the hostname annotation to ${IP}.nip.io when provisioning a loadbalancer that uses the proxy protocol?

This would make it much easier since it would essentially eliminate the need to edit the initial deployment/manually override the annotations on the ingress controller (in case it would be the only override).

The OpenStack CCM does a similar thing: https://github.com/kubernetes/cloud-provider-openstack/pull/1449

This was also proposed by @regnerisch in https://github.com/digitalocean/digitalocean-cloud-controller-manager/issues/291#issuecomment-1712844208

Or, as a different approach: Support https://github.com/kubernetes/enhancements/issues/1860 even though it's still in beta?

I believe this has already been implemented in other CCMs (e.g. here).

Thank you!