Wrong depends on Debian package

alama commented 5 years ago

Please only create a Github issue for bugs related to the code itself. If you are experiencing an issue with sending metrics, display graphs, errors from the agent, etc, please contact https://cloudsupport.digitalocean.com/s/ so we can provide support

Before opening an issue, make sure there is not a similar issue already open

Describe the problem

Debian packages depends on cron when it should be cron-daemon

Steps to reproduce

Install systemd-cron to replace cron

Expected behavior

System Information

Distribution and version: Debian 9.8

do-agent information:

Paste the entire output

/opt/digitalocean/bin/do-agent --version: Not Found

Ubuntu, Debian

apt-cache policy do-agent:

root@gitlab:~# apt-cache policy do-agent
do-agent:
  Installed: (none)
  Candidate: 2.1.3
  Version table:
     2.1.3 500
        500 https://repos.insights.digitalocean.com/apt/do-agent main/main amd64 Packages
     2.0.2 500
        500 https://repos.insights.digitalocean.com/apt/do-agent main/main amd64 Packages
     2.0.1 500
        500 https://repos.insights.digitalocean.com/apt/do-agent main/main amd64 Packages
     2.0.0 500
        500 https://repos.insights.digitalocean.com/apt/do-agent main/main amd64 Packages
     1.1.3 500
        500 https://repos.insights.digitalocean.com/apt/do-agent main/main amd64 Packages

blockloop commented 5 years ago

cron-daemon is a virtual package and has no installation candidate. I believe you have to specify either systemd-cron or cron explicitly.

https://packages.debian.org/stretch/cron-daemon

blockloop commented 5 years ago

Sorry I misunderstood. You're talking about the "Depends on" within the deb package. I believe we can specify cron-daemon and have the OS select the correct package. We'll take a look at this. Thanks for reporting.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

alama commented 5 years ago

The do-agent package version 2.2.4 in the repos still depend on cron, not and cron-daemon

QuLogic commented 2 years ago

If you applied #266, then the package wouldn't need to depend on cron at all.

RosstheRoss commented 2 weeks ago

Solving this for droplet-agent was trivial (ref: digitalocean/droplet-agent#134).

Solving this for this package does not seem to be publicly possible. A cursory search does not show that building the package is done with the Makefile like it was for droplet-agent.

digitalocean / do-agent