Additional test case for highlight

digitalocean / do-markdownit

Markdown-It plugin for the DigitalOcean Community.

https://www.digitalocean.com/community/markdown

Apache License 2.0

85 stars 19 forks source link

Additional test case for highlight #118

Closed GroophyLifefor closed 3 months ago

GroophyLifefor commented 3 months ago

Type of Change

Build Scripts:
Markdown-It Plugins:
SCSS Styling:
PrismJS Integration:
Something else: Additional test case

What issue does this relate to?

Obtaining more stable products
It's also related to #70 and #115

What should this PR do?

Converting a practice that works code-side but not render-side into a test

What are the acceptance criteria?

Need to run npm test on local before this pr is approved.

GroophyLifefor commented 3 months ago

I'm not really sure I follow the intent of this test? It seems to just be testing a highlight within a single line, which is already covered by existing cases.

If this is meant to test in the context of #115, then it is not a correct test as syntax highlighting from Prism is not active in these tests.

@MattIPv4 Hi Matt, my intention is not to put it through a full test phase, I just wrote a small test while trying to solve the problem in issue and I thought why I would not contribute, and if it's not deemed necessary, that's fine.

MattIPv4 commented 3 months ago

Understood, yeah, I don't think test case adds anything worthwhile, so I'll close this. Appreciate you taking a look at the issue though.