digitalocean / doctl

The official command line interface for the DigitalOcean API.
https://docs.digitalocean.com/reference/doctl/
Apache License 2.0
3.26k stars 396 forks source link

Add --wait flag to databases resize command #1585

Closed loosla closed 1 month ago

loosla commented 2 months ago

What is the problem this feature would solve? Please describe. doctl aims to be useful in scripting. One way it does this is by providing a --wait flag for long running, async operations to block until they are complete rather than making the user implement polling in their own script. Some examples include:

Currently the doctl databases resize command does not have a --wait flag.

Describe the solution you'd like Add a --wait flag to the doctl databases resize command. It should poll the /v2/databases/$DATABASE_ID/resize, blocking until the database cluster's status attribute moves from resizing to online.

Additional context Following the code path starting here demonstrates how doctl database create's --wait flag is implemented:

https://github.com/digitalocean/doctl/blob/de1918ad1ee4b1e523c335fa9254e85d415d18aa/commands/apps.go#L282

Yordaniss commented 1 month ago

Hello @loosla This one sounds interesting. Can you please assign this issue to me? 🙂 Thanks

SkySingh04 commented 1 month ago

This looks like a fun issue, Will be working on this!

Yordaniss commented 1 month ago

Hey @SkySingh04 sorry i already started working on this and already created a PR ^^