search

digitalocean / doctl

The official command line interface for the DigitalOcean API.
https://docs.digitalocean.com/reference/doctl/
Apache License 2.0
3.27k stars 396 forks source link

Can't (un)set result limit count #975

Closed WoLfulus closed 3 years ago

WoLfulus commented 3 years ago

I made some automation using doctl but I just found out (when things broke 😆) that the results are getting limited to 25 and there's no flag to "unlimit" it, thus I assumed it would return all of them.

Basically I have ~40 apps on DigitalOcean App Platform and doctl apps ls is showing me only those first 25.

Am I missing something? --help doesn't show any flags to set the return limit

Using latest version on windows and downloaded from releases.

andrewsomething commented 3 years ago

DigitalOcean API responses are paginated. Unfortunately, it looks like this was not handled when apps support as initially added to doctl. We'll need to make a few changes to support this.

Thanks for flagging this issue!

rijkvanzanten commented 3 years ago

@andrewlouis93 Do you happen to have a clearer overview of the changes that are needed to support this? I'm down to give it a shot in a PR, but I'm not (at all) familiar with the internal of doctl (yet) 🙂

andrewsomething commented 3 years ago

Hey @rijkvanzanten! Thanks for the offer, but the work is already in progress. Take a look at the linked PRs to see what this involves. If there's another issue that piques your interest, please feel free to tag me. I'd be very happy to break down any needed changes for you.

rijkvanzanten commented 3 years ago

So fast! Thanks 👍🏻

andrewsomething commented 3 years ago

The fix for this should now be available: https://github.com/digitalocean/doctl/releases/tag/v1.59.0