digitalocean / droplet-1-clicks

Packer build scripts for DigitalOcean Marketplace 1-clicks.
MIT License
117 stars 63 forks source link

Dokku Droplet 1-Click Update #122

Closed v-aisac closed 1 year ago

v-aisac commented 1 year ago

Tested successfully : image

v-aisac commented 1 year ago

Right after Droplet creation Dokku is not accessible from ip image

v-aisac commented 1 year ago

it looks like Dokku is running okay, but is inaccessible from outside image image image

josegonzalez commented 1 year ago

Right after Droplet creation Dokku is not accessible from ip image

We've long removed the setup web ui as it was a security risk - folks were forgetting to run through it and then someone else would come in, add their key, and use the server as a bitcoin miner.

I think the correct thing to do would be to setup the same sort of MOTD/nginx landing page that you do (did?) for Gitlab, prompting a user to ssh onto the box to continue setup. You could also call dokku apps:create 00-default and then slot in a dummy /home/dokku/00-default/nginx.conf for the app if you want to do it the Dokku way.

josegonzalez commented 1 year ago

it looks like Dokku is running okay, but is inaccessible from outside image image image

I think that makes sense. That packer domain isn't a valid one, so of course hitting it wouldn't resolve, DNS-wise.

v-aisac commented 1 year ago

it looks like Dokku is running okay, but is inaccessible from outside image image image

I think that makes sense. That packer domain isn't a valid one, so of course hitting it wouldn't resolve, DNS-wise.

Thanks for your answers. My bad, I was sticking too much to the old description. After turning off vhosts and allowing a port for my app I was able to access it: image

I will need some time to rewrite Dokku description based on my experience with Dokku so far.

I will include steps like adding public keys, pushing a sample app (ruby-getting-started) and also vhosts disable so people can see it work right away (and also link to dokku domain wiki).

What do you think, should I add/remove some steps?

josegonzalez commented 1 year ago

I don't think it should disable vhosts - on boot, we ask a user to set a domain via motd. The VHOST file should probably not be populated for image-based installation so that folks get that message. I feel like a lot of folks will expect a vhost to work otherwise, so disabling it by default seems like a poor experience.

v-aisac commented 1 year ago

Hey! I have updated the description a bit, made sure that following every step results in successful deployment and just clicked to publish the new version. We should see it live soon!

josegonzalez commented 1 year ago

Should I update my automation to target creating a new PR to this repo every time we make a new release of Dokku?

josegonzalez commented 1 year ago

@v-aisac it looks like the description still references a web ui. Is it possible to get that updated? https://marketplace.digitalocean.com/apps/dokku