search

digitalocean / droplet_kit

DropletKit is the official DigitalOcean API client for Ruby.
MIT License
512 stars 150 forks source link

Rubocop integration? #298

Closed ShockwaveNN closed 2 years ago

ShockwaveNN commented 2 years ago

Hi, what authors of this gem thinks about rubocop integration?

I usually ask authors before starting integrating it, since sometimes people are strongly against it. If it's OK I can make a sample PR with change

mikeberezowski commented 2 years ago

Thanks for reaching out. It's a holiday here today so the team is off but we will evaluate this and make a decision next week.

Thanks again for your interest in contributing to DO open source.

andrewsomething commented 2 years ago

Hi @ShockwaveNN,

Thanks for the offer to integrate the project with rubocop. I think this would be a great addition. How are you thinking of approaching it, as GitHub Action workflow?

Unfortunately, running rubocop against this project shows that we have quite a few "convention" level issues and even a few warnings. So we may need to incrementally enable rules as we clean things up.

ShockwaveNN commented 2 years ago

Totally agree about GitHub workflows, it will be the easiest part of the taks

I'll try to make proof of the concept tomorrow, and fix any obvious errors I'll find and we can discuss some other, not so obvious rules after that

andrewsomething commented 2 years ago

Closed via #299