search

digitalocean / droplet_kit

DropletKit is the official DigitalOcean API client for Ruby.
MIT License
512 stars 150 forks source link

Add rubocop support #299

Closed ShockwaveNN closed 2 years ago

ShockwaveNN commented 2 years ago

Implement #298

ShockwaveNN commented 2 years ago

cc @andrewsomething

How did it look like? It's only a start but I think you get a general idea

One side note - to make this code ruby-2.5 compatible I made some ugly if else

Is it possible to drop ruby-2.5 support? This version is EOLed more than a year ago. I can make a separate PR for that if it's ok

andrewsomething commented 2 years ago

@ShockwaveNN This is a great start! Dropping support for Ruby 2.5 sounds reasonable to me as well.

ShockwaveNN commented 2 years ago

@andrewsomething Great, I'll continue to fix issues this week and notify you then I get to some finishing point

ShockwaveNN commented 2 years ago

@andrewsomething I think I'm done, for now, I've resolved all easily fixable errors\warnings and probably do not break any parts of the code, all other changes require more precise work so maybe it can be done in the future