search

digitalocean / marketplace-partners

Image validation, automation, and other tools for DigitalOcean Marketplace Vendors and Custom Image users
Other
193 stars 98 forks source link

small improvements #135

Closed coryschwartz closed 3 years ago

coryschwartz commented 3 years ago

This solves two issues

  1. apt-get upgrade does not reliably upgrade the system. I'm not really confident the incantation I have in this PR covers all cases, but it does cover what I'm trying to do right now. Currently, if you attempt to upgrade digitalocean's Ubuntu 20.04 image using simply apt-get upgrade, apt will prompt the user for a decision about what to do about openssh configuration. --force-yes, -y and other options are not sufficient to suppress it, so I had to pass an option that I'm going to keep the old config

  2. The dd command is too slow, but it can be sped up substantially if you specify a block size. 4096 is a common choice since it is a typical block size.

I also erased lines that truncated lastlog and wtmp since it looked like that was already being truncated earlier in the script.

coryschwartz commented 3 years ago

Regarding the apt-get update thing, I just noticed you have another issue with the same problem.

https://github.com/digitalocean/marketplace-partners/issues/133

jgannondo commented 3 years ago

@coryschwartz thanks for the PR. Someone from the team will review it shortly.

pachadotdev commented 3 years ago

it can be merged now