digitalocean / nginxconfig.io

⚙️ NGINX config generator on steroids 💉
https://do.co/nginxconfig
MIT License
27.66k stars 2.04k forks source link

Add Japanese translation #368

Closed Ippey closed 2 years ago

Ippey commented 2 years ago

Type of Change

What issue does this relate to?

None

What should this PR do?

What are the acceptance criteria?

MattIPv4 commented 2 years ago

:wave: Hey @Ippey, would you mind updating the Copyright xxxx value in the files you've modified to be 2022?

I've also just merged #366 which added two new strings that your language pack will need 💙

Tyvm!

Ippey commented 2 years ago

@MattIPv4 I've just modified it!

Ippey commented 2 years ago

I'm sorry. I added disableHtmlCaching, enableDisableHtmlCaching translation in ja. 🙏

5idereal commented 2 years ago

Hi, could you take a look at the suggestions I made above?

Ippey commented 2 years ago

Hi, @SiderealArt ! Does it mean that I have to modify year 20** to 2022 not only in the ja folder's files but also other languages files I modified?

5idereal commented 2 years ago

Yes, as @MattIPv4 said earlier.

Ippey commented 2 years ago

@MattIPv4 I also modified every languages.js.

Thank you, @SiderealArt !

5idereal commented 2 years ago

I forgot to click comment. I meant these suggestions. Sorry for bothering you again. 😥

Ippey commented 2 years ago

@MattIPv4 @SiderealArt Thank you for your suggestions. I corrected them.

MattIPv4 commented 2 years ago

Hey, @Ippey - Thanks a ton for this sweet PR! 😄

Would you please shoot me an email when you get a chance? mcowley at digitalocean dot com 🎉