search

digitalocean / nginxconfig.io

⚙️ NGINX config generator on steroids 💉
https://do.co/nginxconfig
MIT License
27.66k stars 2.04k forks source link

Allow custom proxy host header to be set #393

Closed MrJmpl3 closed 2 years ago

MrJmpl3 commented 2 years ago

Type of Change

What issue does this relate to?

Trying to fix: #382

What should this PR do?

Move the proxy_set_header Host to per domain config

What are the acceptance criteria?

Well, missing translations with the key 'proxyHeaderOverride', also in Spanish, I think the translation is 'Reemplazo de cabecera del proxy' or only 'Reemplazo de cabecera' because 'del proxy' is redudant.

In another languages, I don't know 😌

If all is correct, please add the tag 'hacktoberfest-accepted', Thanks

MrJmpl3 commented 2 years ago

Oh, the test failed because the missing translation, and now? It's 'Google translate' time?

MattIPv4 commented 2 years ago

@MrJmpl3 You can leave the strings in English in each of the i18n files and add // TODO: translate comments to each line (you'll find a few of these already in the i18n files)

MrJmpl3 commented 2 years ago

👋 Could you make sure the copyright year is bumped in the header of any file you've touched?

Ok, I update the year of copyright

MrJmpl3 commented 2 years ago

👀 Two more things, sorry!

* Could apply the `'Proxy header override'` ->  `'Proxy Host header'` change to all the i18n files?

* Can you change the key we're using in all the logic from being `proxyHeaderOverride` to `proxyHostHeader`? We override quite a few headers, but this setting is specifically the host header

ok, wait some minutes