digitalocean / nginxconfig.io

⚙️ NGINX config generator on steroids 💉
https://do.co/nginxconfig
MIT License
27.66k stars 2.04k forks source link

Husky and lint-staged #396

Closed MrJmpl3 closed 1 year ago

MrJmpl3 commented 2 years ago

Feature request

Feature description

I think husky and lint-staged can be good to the project

How the feature is useful

Husky and lint-staged prevent commits if some commands fails like eslint or prettier, and maybe can made a standard of the commit message with commitlint

MattIPv4 commented 2 years ago

👋 I'm not a fan of commit message standards generally, I prefer just having commit names that make sense in the context of what you're doing.

That being said, I'd be down for adding a basic git hook that runs eslint across files being staged.

MrJmpl3 commented 2 years ago

That can be do it with husky and lint-staged in the pre-commit hook, If you want, I can make a PR with that

PD: Also exists stylelint, It's a linter but for css

MattIPv4 commented 2 years ago

PD: Also exists stylelint, It's a linter but for CSS

Yah, this project uses it :)

TrendyTomorrow commented 1 year ago

Can you assign this to me? I would love to work on this!

MattIPv4 commented 1 year ago

Sure @amrittimalsina :)