Closed nywilken closed 7 months ago
Hey @nywilken, thanks for this! Most of our team is out until Monday for American Thanksgiving, so we'll have a look at this then.
Thank you @bentranter. There are a few small updates that need to be made to complete the PR but please feel free to review the docs when you or the team have time. lbajolet-hashicorp will be assisting in getting this ready over the next couple of days.
Hi @andrewsomething,
Pinging on this issue, sorry I couldn't get to updating the action beforehand, I've been busy on other things recently. I've added a ticket on our internal boards to keep track of this, and have scheduled work on it in the coming weeks.
In the meantime, may I ask if you're able to merge this? We have migrated over to the new integrations system recently, so as of now the documentation for this plugin is not available anymore on our documentation site, and we've received reports (for example this issue) that users can't access them anymore.
If you prefer not to merge the action for publishing automatically on release because of the ordering issue, please feel free to remove it from the repo for now, we'll open a PR with it once we've fixed the scheduling problem.
@lbajolet-hashicorp After mergining, I attempted to run the manual action for our latest release, v1.2.2. It failed with:
Error: Failed to notify release: API responded with [400]
Are there any additional steps we need to take to get the docs back up?
Well that is my bad, it looks like we didn't include the strip-version
that removes the leading v
in front of the version number, and our APIs reject that kind of version name, hence the 400 you received.
I'll open a PR to fix that right now, sorry about that!
Oh looks like this is how we implemented it for all our plugins, without the strip-version job, presumably because we assumed we'd call it without the leading v
in it. In retrospect though, it is probably better to make sure it isn't, so I'll see to test this in another repo, and I'll push that to every plugin we know of.
In the meantime, you will be able to call it with 1.2.2
as argument instead of v1.2.2
, and that should succeed.
:wave: fellow Packer maintainer working on migrating your plugin to the Packer integration framework.
This change takes the necessary steps to register this plugin as an official Packer integration. Integrations can be found on the Packer integration portal at https://developer.hashicorp.com/packer/integrations.
The pull-request consists of the following changes:
metadata.hcl
for registering the plug-in and it components as integrations. Details on the contents, along with a description of the attributes, can be found at https://github.com/hashicorp/integration-template..web-docs
directory for serving the fully render documentation as the integration docs.make build-docs
for syncing changes to thedocs
directory to the.web-docs
directory.Changes to the integration docs can be made at plugin release via the
notify-integration-release-via-tag
workflow or manually by running thenotify-integration-release-via-manual
workflow.Details on how the Integration framework pipeline works can be found at https://github.com/hashicorp/packer/pull/12702
TODOs
.web-docs/metadata.hcl
.