search

digitalocean / terraform-provider-digitalocean

Terraform DigitalOcean provider
https://registry.terraform.io/providers/digitalocean/digitalocean/latest/docs
Mozilla Public License 2.0
509 stars 278 forks source link

Enable failing linter: errcheck #1227

Closed loosla closed 1 month ago

loosla commented 1 month ago

Some linters are disabled. Please enable the failing errcheck linter and make the necessary changes to ensure that the checks pass.

Steps:

  1. Uncomment errcheck in https://github.com/digitalocean/terraform-provider-digitalocean/blob/6593bad18758574921e74670c9df08ca8e982566/.golangci.yml#L30
  2. Run make lint from the root directory of the repo to see the issues to fix
  3. Fix the issues to make make lint pass
TheMarvelFan commented 1 month ago

Hi,

Iis anyone working on this issue? I would like to take it up if no one is.

Thanks.

loosla commented 1 month ago

Hey @TheMarvelFan, While there aren't any existing PRs for this issue, it would be fantastic if you could create one! To link your PR to the issue, just include keywords like closes #1227 in the description. You can find more details here: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword. Thanks for contributing—we can’t wait to see your PR!

TheMarvelFan commented 1 month ago

Hi @loosla ,

I have created the PR to fix this issue. Please review the changes and let me know if any further modifications are required.

Thanks!

TheMarvelFan commented 1 month ago

@loosla

Also before merging the PR, I request you to assign this issue to me, as well as change the label on this issue from 'hacktoberfest' (with a small 'h') to 'Hacktoberfest' (with a capital 'H'), as the Hacktoberfest website is only detecting issues labeled with 'Hacktoberfest'.

Hope this is understandable.

Thanks!