digitalocean / terraform-provider-digitalocean

Terraform DigitalOcean provider
https://registry.terraform.io/providers/digitalocean/digitalocean/latest/docs
Mozilla Public License 2.0
509 stars 278 forks source link

Revert change moving from logging.NewTransportWithRequestLogging from logging.NewTransport. #1243

Closed andrewsomething closed 1 month ago

andrewsomething commented 1 month ago

In https://github.com/digitalocean/terraform-provider-digitalocean/pull/1237, a number of deprecated methods were update to allow for enabling additional staticchecks. Unfortunately, moving from logging.NewTransport to logging.NewTransportWithRequestLogging will require additional work to maintain the current level of detail in our debug logging.

Currently debug logging contains the following error message and does not include the actual details for the request and response bodies:

2024-10-09T10:51:36.704-0400 [DEBUG] provider.terraform-provider-digitalocean: Received HTTP Response: Date="Wed, 09 Oct 2024 14:51:36 GMT" X-Response-From=service new_logger_warning="This log was generated by a subsystem logger that wasn't created before being used. Use tflog.NewSubsystem to create this logger before it is used."

I've used nolint:staticcheck inline rather than disabling the check again.