digitalpalidictionary / dpd-db

13 stars 8 forks source link

pass superscripter as binding to templates #16

Closed gambhiro closed 9 months ago

gambhiro commented 9 months ago

Instead of importing with inline Python in the template, the function can be passed as an argument.

This fixes the superscripter module not being discovered by pyinstaller and erroring out compiled executables in which this template is used.

gambhiro commented 9 months ago

Ven @bdhrs is this PR ok?

bdhrs commented 9 months ago

If it doesn't break anything, please always feel free to merge

gambhiro commented 9 months ago

If it doesn't break anything

☢️

It's pretty simple but I wanted to make sure you are aware of the code change and the reason.

gambhiro commented 9 months ago

xkcd: every change breaks someone's workflow https://xkcd.com/1172/

bdhrs commented 9 months ago

xkcd: every change breaks someone's workflow crying

On Sat, 2023-12-16 at 03:42 -0800, Gambhiro wrote:

xkcd: every change breaks someone's workflow https://xkcd.com/1172/ — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>