search

digitalpalidictionary / dpd-db

Digital Pāḷi Dictionary
https://digitalpalidictionary.github.io/
15 stars 9 forks source link

don't stop build scripts for user input #17

Closed gambhiro closed 10 months ago

gambhiro commented 10 months ago

Since you are reading a user's custom values from config.ini already, it is strange to stop a build script in the middle to ask for user input.

The expected behavior would be to continue with the default value without prompting.

I was caught by this a handful of times, when downloading a fresh clone or removing config.ini to reset settings, then starting the db build, leaving to do sth else, and when I come back, it halted waiting for me to press enter.

"Enter your GoldenDict directory prompt" here:

tools/goldendict_path.py#L18

Devamitta commented 10 months ago

now by this commit if you run make_dict.sh with default settings in config it will not interrupt. But to be clear, build_db.sh is not affected by goldendict_path.py#L18