Change scope for properties in DigitalPianism_TestFramework_Model_Config

digitalpianism / testframework

A simple test framework repo for Magento 1

49 stars 14 forks source link

Change scope for properties in DigitalPianism_TestFramework_Model_Config #5

Open marcinwarzybok opened 7 years ago

marcinwarzybok commented 7 years ago

Hello,

Is this possible to change scope (from private to protected) for properties in DigitalPianism_TestFramework_Model_Config ($modelTestDoubles, $resourceModelTestDoubles) ? I want extend DigitalPianism_TestFramework_Model_Config in my own Config file and work on framework properties. Of course I can make pull request for it.

digitalpianism commented 7 years ago

@marcinwarzybok yeah sure, go for it. I'll merge as soon as I get your PR

tim-bezhashvyly commented 4 years ago

Protected properties are evil and must be avoided.