search

digitalpulp / ballast

Ballast development environment for Drupal
GNU General Public License v2.0
18 stars 2 forks source link

Refactor to workaround docker-compose error #16

Closed FatherShawn closed 6 years ago

FatherShawn commented 6 years ago

An recent regression in docker-compose 1.20.0 prevents Ballast from running exec on macOS: https://github.com/docker/compose/issues/5824

The issue was fixed immediately for the next version of docker-compose but we should refactor to avoid the error during the life of 1.20.0. This will have the side benefit of moving along the second tasks in #13 and #15.

FatherShawn commented 6 years ago

Moving docker injection commands from ahoy to robo to provide OS logic is blocked by https://github.com/consolidation/Robo/issues/711

FatherShawn commented 6 years ago

I realized that we can keep os specific commands in ahoy and use Robo on setup to move an os specific version into place.

FatherShawn commented 6 years ago

The regression was fixed in docker-compose 1.21 If you find this issue and you are on docker-compose 1.20 then bumping to the next version will be the fix. We'll leave the one workaround on rebuild in place because we also made ui improvements.