search

digitalr00ts / fizzbuzzx

An unnecessarily over-engineered fizzbuzz solution
Apache License 2.0
2 stars 2 forks source link

✨: Add github actions #21

Closed pelmini closed 3 years ago

pelmini commented 3 years ago

Resolves Issue #7

drts01 commented 3 years ago

Should add Closes #21 to git commit to automate closing (and linking) of the issue this PR addresses. Do you know how to do multi-line commits. Easiest way it to not do the commit message at the cli, and let git open vim.

see, https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

drts01 commented 3 years ago

If we want to have a cleaner commit history, I think having one commit and Closes #21 going in the body of the commit. https://stackoverflow.com/a/42078093/2079786

I retract my comment about using vim for commit msg being easier. using two -m is easier. 😛 (see the Stack Overflow answer).

Think you can rebase and squash the commits? Rewriting history! lol

drts01 commented 3 years ago

Wait. The PR is #21. The commit msg should be closing Issue #7. The PR will close when it is merged.

pelmini commented 3 years ago

oops my bad. Thanks for catching that!