digitalroastery / weblounge

Web Content Management System
12 stars 4 forks source link

Remove asynchronous write methods from content repository #381

Closed myniva closed 8 years ago

myniva commented 8 years ago

With the first release of Weblounge 3.x, asynchronous write methods were added to the content repository. The reason behind this was quite simple: Updating the internal index of the content repository was extremely slow and write operations therefore blocked calls for sometimes more than a second.

With the replacement of the internal index by a Elasticsearch based index, write operations got way more efficient again.

The internal handling of the asynchronous write operations has always been tedious. As randomly failing unit tests have proven (see #368 and #369), the implementation was never working completely reliable.

With the next major release of Weblounge (4.x), the content repository layer will be re-designed from the ground to eliminate some of the existing limitations (object model, distributed setup).

All in all, it is acceptable to remove asynchronous write operations from the content repository for now as there is no major drawback and it improves stability of the code base on the other side.

myniva commented 8 years ago

Fixed by pull request #382