search

digitalsparky / jekyll-minifier

Jekyll HTML/XML/CSS/JS Minifier utilising yui-compressor, and htmlcompressor
GNU General Public License v3.0
245 stars 25 forks source link

Not working with Ruby 2.3/Jekyll 3.2.0? #10

Closed arclabch closed 8 years ago

arclabch commented 8 years ago

On a fresh installation of Ruby 2.3 with Jekyll 3.2.0, jekyll-minifier gives me the following error:

jekyll 3.2.0 | Error:  uninitialized class variable @@mtimes in Jekyll::StaticFile
Did you mean? @mtimes mtimes

I temporarily worked around the issue by editing line 87 of lib/jekyll-minifier.rb and changing @@mtimes for @mtimes but as I don't know ruby, I'm not sure what the implications are. :-)

digitalsparky commented 8 years ago

Hi @arclabch I'll check it out and get back to you. Thanks for contacting me :).

sandys commented 8 years ago

+1 - I have the same issue with exactly the same error.

digitalsparky commented 8 years ago

It looks like the change occurred here:

https://github.com/jekyll/jekyll/commit/0f74db413110ae7cb435bbd2d7f21a2918dd9cfe

digitalsparky commented 8 years ago

Fixed in release 0.0.9, pushed to rubygems.

sandys commented 8 years ago

works great! thanks.

arclabch commented 8 years ago

Great, thank you!