search

digitalsparky / jekyll-minifier

Jekyll HTML/XML/CSS/JS Minifier utilising yui-compressor, and htmlcompressor
GNU General Public License v3.0
245 stars 25 forks source link

Some bugs in CSS minifying #16

Open ovflowd opened 7 years ago

ovflowd commented 7 years ago

I saw that the script minifies CSS also, but has some bugs. If the word 0 is found, removes all postfixes added on it.

(Like removing the % of 0%, since in CSS 0% = 0)

But this makes 0s became 0 in Transitions and also transforms 0% from transitions in 0. (That creates bugs in the syntax)

Why not using CSSMINIFY package? Like Explained in #13

digitalsparky commented 7 years ago

Hi sant0ro, the packag eis using the cssminify package as of v0.0.7. Unfortunately the cssminify package appears to be no longer supported, I'll try and find a valid alternative.

digitalsparky commented 7 years ago

I've forked a pull request to the original cssminify package and rolled that package out as cssminify2, then updated jekyll-minifier to use cssminify2, this issue should now be resolved.

ovflowd commented 7 years ago

Thanks @digitalsparky !

ovflowd commented 7 years ago

It's seems that sadly the bugs continues. The CSSMinify continues removing the postfixes (from 0 absolute values).. and this bug transitions and animations.

simonkurka commented 5 years ago

@digitalsparky I can confirm: issue not resolved.

lsli8888 commented 2 years ago

Unfortunately, I'm still seeing this issue as well in 0.1.10.

digitalsparky commented 2 years ago

Sorry all, I've had a bit of a nightmare last few years and haven't really been able to do much. (I was in a car crash (not at fault) which caused a spinal injury.) I've been both in copious amounts of pain and also a pain killer induced zombie-mode... I'll get to this when I have some more capacity for concentration.

If anyone would like to help with this, please feel free to reach out.

Matt

myst729 commented 1 year ago

@digitalsparky Wish you get better soon.

I also run into this issue, but a work-around DOES exist. For those who still suffer this issue, the answer is initial or unset keyword. Since transition-duration is not inheritable, both will reset the property to its initial value —0s.

transition-duration: initial;