Please, remove the comments from css files

digitalsparky / jekyll-minifier

Jekyll HTML/XML/CSS/JS Minifier utilising yui-compressor, and htmlcompressor

GNU General Public License v3.0

245 stars 25 forks source link

Please, remove the comments from css files #19

Closed ivan-meridianbanc-com closed 7 years ago

ivan-meridianbanc-com commented 7 years ago

Minifier of css files leave comments /** * Reset some basic elements */ `/*!

Bootstrap v3.3.5 (http://getbootstrap.com)
Copyright 2011-2015 Twitter, Inc.
Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE) //! normalize.css v3.0.3 | MIT License | github.com/necolas/normalize.css */`

digitalsparky commented 7 years ago

Hi,

The legal comments are left in by the css minifier, as per the license requirements. These are identified using /*! and //! comment prefixes (meaning preserve).

The CSS minifier honours these prefixes.

Please read the licenses of your includes before attempting to remove these notices from your sources prior to building.

All other comments are removed.

ivan-meridianbanc-com commented 7 years ago

Should this comment be removed ?

/** * Reset some basic elements */

digitalsparky commented 7 years ago

Yes, they should be, if they're not part of a parent important content block. Please file a bug on https://github.com/digitalsparky/cssminify/ if you're experiencing these issues.

Thanks :).