This fixes persistent issues with excluding files. In essence, the coercion from string keys to symbol keys in output_html violated idempotency; i.e. the first attempt to get the exclude setting would work via a string, but then failed in subsequent attempts, since a symbol would be required. This pull request just uses string keys throughout.
I also greatly simplified how exclusion checking works by making use of Kernel#Array, Array#any?, and Hash#dig.
sonnym
commented
7 years ago
This fixes persistent issues with excluding files. In essence, the coercion from string keys to symbol keys in
output_htmlviolated idempotency; i.e. the first attempt to get theexcludesetting would work via a string, but then failed in subsequent attempts, since a symbol would be required. This pull request just uses string keys throughout.I also greatly simplified how exclusion checking works by making use of
Kernel#Array,Array#any?, andHash#dig.