search

digitalsparky / jekyll-minifier

Jekyll HTML/XML/CSS/JS Minifier utilising yui-compressor, and htmlcompressor
GNU General Public License v3.0
245 stars 25 forks source link

Fix JS and CSS combination minification #36

Closed kenman345 closed 6 years ago

kenman345 commented 6 years ago

Closes #21 Closes #14

Basically we were not having the file re-evaluate and use the other compressors when its been put behind a front matter block. I added the change to both Page and Document as I was not sure which was the one absolutely needed but i did test this locally for myself and didnt run into any trouble. Perhaps you can make adjustments if you know something more than I do as I am still new to this.

kenman345 commented 6 years ago

changes made but please go ahead and make edits if you see anything else that needs adjustment. I would very much love if this were merged and put into a new gem build for my Jekyll site that we build with Travis that uses the GEM can make use of

chris-huxtable commented 6 years ago

Looks better. You will have to wait for @digitalsparky for it to be merged.

digitalsparky commented 6 years ago

Sorry folks, been super busy lately, merged. thanks for your contribution

kenman345 commented 6 years ago

no worries, none of the issues actually told you how to fix. I did some digging myself to identify what it might be and so I made a PR. Thanks for the plugin, cant wait for this to get a release

digitalsparky commented 6 years ago

Released