search

digitalsparky / jekyll-minifier

Jekyll HTML/XML/CSS/JS Minifier utilising yui-compressor, and htmlcompressor
GNU General Public License v3.0
245 stars 25 forks source link

comments are not removed from css #4

Closed ssbarnea closed 8 years ago

ssbarnea commented 9 years ago

While clearly it did some kind of minifying, it seems that all the comments are still inside the CSS file. Is this normal? Alternatives?

digitalsparky commented 8 years ago

There are comments that may be required to remain in source, ie: GPL notifications etc. CSS and JS minification is done by the YUI Compressor, and as such out of scope for this project.

I will, however, look at replacing the YUI components of this project, as it appears those are no longer maintained.

digitalsparky commented 8 years ago

I've found an issue in which HTMLcompressor wasn't removing comments in the HTML, however YUI Compressor is supposed to be doing the removal it's self, without configurations.

At this stage, I needto find a new compressor

digitalsparky commented 8 years ago

Switched to Uglifier and CSSminify, added HTML comment removal by default, pushed new version to rubygems.