digitalsparky / jekyll-minifier

Jekyll HTML/XML/CSS/JS Minifier utilising yui-compressor, and htmlcompressor
GNU General Public License v3.0
245 stars 25 forks source link

Have bug since last update 0.1.8 #43

Closed novus213 closed 5 years ago

novus213 commented 5 years ago

Hi, Have this error message since last update jekyll 3.8.5 | Error: undefined local variable or method `compressed' for # Did you mean? compress compressor To fix , i have downgrade the call of plugin version for moment.

Edit: i confirm that with the 0.1.6 tag is working again (but not with 0.1.8)

MindfulMinun commented 5 years ago

I'm having this same problem. It looks like it has to do with the compress_javascript setting. Turning it off gets rid of the issue.

Here's my console output:

mindfulminun:benjic.xyz mindfulminun$ JEKYLL_ENV=production bundle exec jekyll build
Ignoring bigdecimal-1.3.4 because its extensions are not built.  Try: gem pristine bigdecimal --version 1.3.4
Ignoring commonmarker-0.17.9 because its extensions are not built.  Try: gem pristine commonmarker --version 0.17.9
Configuration file: /Users/mindfulminun/Documents/GitHub/benjic.xyz/_config.yml
            Source: /Users/mindfulminun/Documents/GitHub/benjic.xyz
       Destination: /Users/mindfulminun/Documents/GitHub/benjic.xyz/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
jekyll 3.8.5 | Error:  undefined local variable or method `compressed' for #<Jekyll::Page @name="H.coffee">
Did you mean?  compress
               compressor

I'm on macOS Mojave v10.14.1 running Jekyll 3.8.5 and jekyll-minifier 0.1.8

alexmerkel commented 5 years ago

I have the same problem on Debian stretch running jekyll 3.8.5, jekyll-minifier 0.1.8 and uglifier 4.1.20. Using jekyll-minifier 0.1.6 with jekyll 3.8.5 and uglifier 3.2.0 works fine.

digitalsparky commented 5 years ago

Thanks @kenchan0130 for the fix, I've been a bit spacey lately (thanks pain killers).. so must have missed it. I've merged and released as 0.1.9. Apologies all.