search

digitalsputnik / DS-Voyager-controller

Application to control Digital Sputnik Voyager lights
0 stars 0 forks source link

FX "Stream" and its FX Settings are not saved in the project #218

Closed marirohtla closed 3 years ago

marirohtla commented 4 years ago

Describe the bug When opening a project that is saved with Stream/Spout: -Lamps do not take on saved Stream/Spout -Lamps do not take on saved FX Settings -Physical lamps do not take on saved Color Wheel settings (only after selecting lamps and opening Color Wheel) -Lamps in UI show correct saved Color Wheel settings, when added to workspace before opening project from Load List -Lamps in UI and also physical lamps take on default color when the lamps are not added to workspace before opening the project from Load List

Setup that was used

To Reproduce Steps to reproduce the behavior:

  1. Select lamps
  2. Click on "Set Effect"
  3. Select "Syphon/Spout Stream"
  4. Open Color Wheel
  5. Select random color
  6. Click on "FX Settings"
  7. Select random FX settings
  8. Click on "FX Mapping"
  9. Click on "Workspace"
  10. Click on "Setup"
  11. Click on "Save Project"
  12. Click on "Save"
  13. Click on "New Project"
  14. Click "OK" on the message prompt
  15. Click on "Load Project"
  16. Select saved Stream project
  17. Click "YES" on the message prompt
  18. Only the saved mapping opens :(

Expected behavior When opening a project that is saved with Stream settings - the settings appear in UI and on physical lamps. OR there could be a message prompt that "Stream cannot be saved"? OR at least Color Wheel settings would appear to the physical lamps as well.

Additional context ALSO: When a current video is not rendered fully to 100% and opening the Stream project from Load list - the last video stays flickering between saved color and current color...

marirohtla commented 4 years ago

@taavetmaask v2.3.40 Stream FX Settings and Color Wheel settings are still not saved. - Not on OSX, not on Windows. When setting Stream as FX:

marirohtla commented 4 years ago

@taavetmaask Mac v2.4.4: Syphon stream from Syphoner comes through to the app, but NOT onto the lamps. Lamps do not respond to the Color Wheel changes in FX Mapping. Color Wheel settings and Stream seems to be saved, but they appear on UI lamp only after Edit Fx is opened. On the physical lamp, nothing happens - only default color. VIDEO

In addition: When deleting a lamp that has Stream and FX mapping set - and adding the lamp into the Workspace - the lamp in UI has the last set Mapping - although nothing was saved.. [VIDEO] Also only after adding the lamp again - the mapping appears on physical lamp and it starts to respond to ColorWheel changes. Still no stream on physical lamps. Possible new issue?(https://drive.google.com/file/d/1yyVLTeSGe1PKBSzKQRxM7DcIQ1wnD9Nj/view?usp=sharing)

marirohtla commented 4 years ago

@taavetmaask Windows v2.4.4: Spout stream from AE comes through into the app and onto the lamps, lamps also respond to Color Wheel changes in FX Mapping, BUT after re-opening the app the Stream in not saved, the mapping is not saved, Color Wheel settings are not saved.

Similarly to Mac it also appears that: When deleting a lamp that has Stream and FX mapping set - and adding the lamp into the Workspace - the lamp in UI and also the physical lamp has the last set Mapping in dafault color

marirohtla commented 4 years ago

@taavetmaask on beta debug v2.4.5 also Delay and FPS are not saved

marirohtla commented 4 years ago

@taavet connected to the issue #345 ?

marirohtla commented 4 years ago

@taavetmaask @TaanielDS This issue is fixed in v2.4.21 - stream and its FX Settings are saved, BUT (as Taavet also commented): DELAY is not saved - as ve decided to keep the slider, this value should also be saved. Also FPS is not saved - not a problem as we decided to lose the slider and fix FPS to 30.

marirohtla commented 4 years ago

@taavetmaask @TaanielDS On v2.4.25 Delay is now saved - issue "fixed" But noticed that on OSX some previously saved projects (most with stream) in the "LOAD" List have an error displayed: image

Is this a problem?

marirohtla commented 4 years ago

Save files .zip

taavetmaask commented 4 years ago

I inspected the files, and as I thought, the following errors seen are not a problem for clients. I only found the error on the saves done on version 2.4 before new features were added (basically the latest updates). Clients don't have the problem because they didn't have any access to that version.

So, how to know, If you have the same problem for now on? A little tip I can recommend is to write the app version in the save file as a prefix. For example: "2.4.13 blue fire".

If the error appears with old versions, then that's a problem, and I have to fix something. It's still good to keep old saves on a test device.

@marirohtla @TaanielDS