search

digitalsputnik / DS-Voyager-controller

Application to control Digital Sputnik Voyager lights
0 stars 0 forks source link

Stream blinks on physical lamps #544

Closed marirohtla closed 3 years ago

marirohtla commented 3 years ago

Describe the bug Syphon/Spout blinks on physical lamps between (default or set) color and stream

NB! This issue happens with v2.6.21/1.802 , but this did not happen with previous pre-release v2.6.14/1.802.

Edited on 07.04.2021

Setup that was used

To Reproduce Steps to reproduce the behavior:

  1. Set FX on lamp
  2. Set Stream on a lamp
  3. Latest set FX blinks black on lamp until it stays black

Expected behavior Streamed should not blink

Additional material https://user-images.githubusercontent.com/50828290/108047450-80776380-704e-11eb-9e82-4aa6eb1cc755.mp4

TaanielAI commented 3 years ago

This seems to be an issue on lamp side as latest effect that was set for some reason blinks through after setting stream.

Olenjan commented 3 years ago

Spout stream does not work in controller v2.6.26 image

Using Release v2.5.60 with voyager v1.808, everything works as intended, no blinking.

marirohtla commented 3 years ago

This issue seems fixed with 1.816/v2.6.62

Olenjan commented 3 years ago

I previously did nothing to fix the issue.

New tests with version 1.816, UI 2.6.79 When adding voyager to scene and updating. Lamp starts blinking.

Blinks between yellow(Default color) and black, in UI and on voyager image

After update, blinking stopped on voyager, but continued in UI. Restarting application, UI and voyager start blinking again

Olenjan commented 3 years ago

Settings white color, blinking stops. Restarting application, UI and Voyager start blinking again

Olenjan commented 3 years ago

Blinking does not occur in STREAM mode, eveything seems to work as intended, including delay. image

TaanielAI commented 3 years ago

@Olenjan

https://user-images.githubusercontent.com/37457282/113870406-79e9aa80-97ba-11eb-98e2-a91a447963f5.mp4

TaanielAI commented 3 years ago

@marirohtla , could you re-test as well? Could it be computer-dependent issue?

Olenjan commented 3 years ago

Seems that the issue is valid. Application sends previously rendering video frame to Voyager.

Prints when valid UDP frame is received.

FI: 198, frame: [13  1  0  8] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.7300293, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.7370307, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.7440326, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.751034, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.7580357, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 199, frame: [13  1  0  8] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.7650368, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.7720385, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.77904, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.7850416, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.7920482, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 200, frame: [12  1  0 10] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.80005, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8070514, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.813053, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8200543, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8270564, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 201, frame: [13  1  0 10] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8340578, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8410597, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8480608, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8550622, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8620641, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 202, frame: [13  2  0 10] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8710663, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8770673, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8830693, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8900702, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 203, frame: [12  1  0 12] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.8970716, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.9040737, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.9110754, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.918077, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.9250784, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 204, frame: [10  1  0  8] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.9320793, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.9390817, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.9470837, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.9520836, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.9590857, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 205, frame: [10  1  0  8] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.966088, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.9730892, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.9800904, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.9870923, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385566.9940968, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 206, frame: [9 1 0 8] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385567.0010984, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385567.0081, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385567.0141008, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
FI: 1455385567.0221026, frame: [0 0 0 0] from <VideoStreamConnection.VideoStreamConnection object at 0xb4b80570>
marirohtla commented 3 years ago

Yes, this also happens on my OSX and Win with v2.6.79/1.816. When Stream is set - latest set FX blinks on lamp until it stays black

Olenjan commented 3 years ago

v1.818 https://github.com/digitalsputnik/DS_Voyager_Artik530_Data/releases/tag/v1.818

Fixed adding video frame indices to Stream buffer. - Now does not. Previously video frames with 0 ... X indices were added to Stream framebuffer and they were used for interpolation in some cases.

Also added: serial_name check for every packet. When serial_name key exists and is a valid value

Olenjan commented 3 years ago

v1.819 https://github.com/digitalsputnik/DS_Voyager_Artik530_Data/releases/tag/v1.819

From release notes:

Fixed phantom STREAM bitmap value that caused 1 index offset when rendering.
Was root cause why VIDEO frame index blinked through.
Index and bitmap did not match, was offset by one. By accident took video frame index that was never meant to be used.
Extra check still remains  to not add VIDEO intended frame to STREAM buffer.
Now also properly zeroes STREAM buffer, fixing index offset error and accidental blinks.
marirohtla commented 3 years ago

This issue seems fixed with v2.6.87&1.819