search

digitaltrails / ddcutil-service

A Dbus ddcutil server for control of DDC Monitors/VDUs
GNU General Public License v2.0
11 stars 1 forks source link

Should the key arguments be unified as a string? #11

Closed digitaltrails closed 7 months ago

digitaltrails commented 9 months ago

Perhaps the display_number and edid_txt parameters could be combined to be a display_key parameter.

It's easy to tell a display number from a base64 encoded EDID with a simple length test. The downside would be that the display_number would have to be passed as a string and converted. Perhaps it's also less self documenting.

Perhaps other kinds of identifiers could also be supported via the same parameter, possibly coupled with setting a flag bit if the key-type is ambiguous.

Perhaps just rename edid_txt to stable_key and leave display_number. Perhaps stable_key is too non-descriptive, most likely, it is always going to be the edid? Maybe we just need to add calls to translate potential other identifiers to edid.

Probably overthinking this, but I'm concerned to future proof the interface.

digitaltrails commented 7 months ago

Scheme currently in place seems to be working OK.