digitaltrails / vdu_controls

VDU controls - a control panel for monitor brightness/contrast/...
GNU General Public License v3.0
114 stars 3 forks source link

D-bus client added in 2.0 is incompatible with python prior to 3.11 #72

Closed digitaltrails closed 7 months ago

digitaltrails commented 7 months ago

Python 3.11 introduced a default argument of 'big' for byteorder for int.from_bytes(b'1', byteorder='big'). That's crept into vdu_controls 2.0 and causes a runtime error when run with d-bus enabled on python versions prior to 3.11.

Patch 6d7d471 now passes 'big' to all int.from_byte calls. This should be safe as it matches what has been tested in python 3.11. All the cases in question involve single-bytes, so 'big' is quite appropriate.

Prior to patching, the work-around is to disable dbus on startup by using the --no-dbus-client command line option, and then permanently set the corresponding option in settings.