digitaltwinconsortium / DTDLParser

Digital Twin Definition Language parser for .NET
MIT License
14 stars 8 forks source link

Update to .NET 8 #117

Closed rido-min closed 12 months ago

rido-min commented 12 months ago

This PR updates all dotnet projects to use net8, the new LTS released earlier this month.

jrdouceur commented 12 months ago

The codegen folders cannot be changed from a fork, because the DTDLParser-PR flow does not work for forks, and it verifies that the code generation proceeds correctly. Can you resubmit this from a branch on this repo?

rido-min commented 12 months ago

this PR is not from a fork, I avoid to update anything in the gen folder, but it still fails because the tutorials cannot be updated.

I'm closing this PR, and sync offline to figure out the best way to proceed.

jrdouceur commented 12 months ago

Try renaming the branch to "meta-gen/net8" and pushing again. This is an annoying quirk of the PR flow; sorry about this.

rido-min commented 12 months ago

and then.. can I update files under dotnet/gen ? I'm wondering how to update the tutorials

jrdouceur commented 12 months ago

bash Develop.sh This will update everything, including tutorials. The PR pipeline will also do this for you, and it will add a commit to your PR branch with the generated files.