digitalungdom-se / digitalungdom-api

GNU Affero General Public License v3.0
2 stars 0 forks source link

A link should be sent with the login code email #8

Closed Nautman closed 3 years ago

Nautman commented 4 years ago

Hi,

I was wondering if there was a link sent with the login code email? If so, what is the structure of the link, i.e.

digitalungdom.se/verify/:bearer

where bearer is email + ":" + loginCode in base64?

Zigolox commented 4 years ago

I think there should be sent with the login code email and that it should be stated that the link is preferred to the text since it is more secure.

kelszo commented 4 years ago

Atm no link is sent

Zigolox commented 4 years ago

We should send a link with a random code. I'm re-purposing this issue for also sending a link.

kelszo commented 4 years ago

I do not see the point so this will be low priority.

Nautman commented 4 years ago

I think it's a very useful feature. Is it possible for you to commit the HTML templates for the SendGrid emails? Perhaps me or @Zigolox can help!

Nautman commented 4 years ago

I don't think this is necessary for MVP.

kelszo commented 3 years ago

Fixed as of commit 6e4072a