search

digitalutsc / islandora_web_annotations

An Islandora module that enables annotation on Islandora objects, following the W3C Web annotation model.
GNU General Public License v3.0
7 stars 5 forks source link

Issue 121 #122

Closed MarcusBarnes closed 7 years ago

MarcusBarnes commented 7 years ago

What does this Pull Request do?

Provides a configuration option to remove the clipper icon that is displayed by default via the large image solution pack (addressing issue https://github.com/digitalutsc/islandora_web_annotations/issues/121).

What's new?

A configuration option to remove the clipper icon that is displayed with content models that use the large image JS.

How should this be tested?

Additional Notes:

If and when an option to hide the clipper icon become available in Islandora Solution Pack Large Image (https://github.com/Islandora/islandora_solution_pack_large_image), we can remove this configuration setting and related code. However, adding this in Islandora Web Annotations helps clean up the interface for some currently known production instances of Islandora Web Annotations that is targeting large images.

Explaining this new configuration option should be included in the documentation.

Natkeeran commented 7 years ago

Works as expected. Nice work. Thank you.