digitalutsc / islandora_web_annotations

An Islandora module that enables annotation on Islandora objects, following the W3C Web annotation model.

GNU General Public License v3.0

7 stars 5 forks source link

Video anno update #128

Closed Natkeeran closed 7 years ago

Natkeeran commented 7 years ago

What does this Pull Request do?

This PR addresses this issue: https://github.com/digitalutsc/islandora_web_annotations/issues/123.

The PID and checksum of the annotation that is created on the server is not available in the annotationCreated event. This is Bug in the library: https://github.com/openannotation/annotator/issues/482.

A fix involving registering a ajaxComplete event to the POST even is suggested here: https://github.com/openannotation/annotator/issues/495. This PR implements that.

How should this be tested?

Get the PR
Create/Open video object
Create an annotation
Immediately after, without clicking the showAnnotations button or reloading the page, edit the annotation
Afterwards, reload the page
The update should be persisted
Review the modified annotation in Fedora to ensure that the datastream contains a valid json-ld