digitalutsc / islandora_web_annotations

An Islandora module that enables annotation on Islandora objects, following the W3C Web annotation model.
GNU General Public License v3.0
7 stars 5 forks source link

chrome browser: fuzzier selection to edit in text box #143

Closed kimpham54 closed 6 years ago

kimpham54 commented 7 years ago

this applies to video annotations

In firefox, when you click on "Add Annotation" then the dialog box appears to enter in text, you can click anywhere inside the white text area to begin adding/editing text.

in Chrome, web annotations is slightly more nitpicky about where to put your cursor before you can start editing/adding text to create an annotation. You need to put your cursor close to the top left corner of the textarea and click before you can begin adding/editing text.

kstapelfeldt commented 7 years ago

Looking at base library behaviour is something we may consider in future releases -

kstapelfeldt commented 7 years ago

Still not considered a blocker. Need to click in upper left-hand corner to activate edit. Only an issue in chrome. Recommend we do put out in release as 'known'

kstapelfeldt commented 6 years ago

need to test to see if this remains an issue in Chrome.

Natkeeran commented 6 years ago

Please use the below context after this PR gets in and test this. We are updating the tinymce editor in that PR.

$context = new stdClass();
$context->disabled = FALSE; /* Edit this to true to make a default context disabled initially */
$context->api_version = 3;
$context->name = 'video_js';
$context->description = '';
$context->tag = '';
$context->conditions = array(
  'islandora_context_condition_content_models' => array(
    'values' => array(
      0 => TRUE,
    ),
    'options' => array(
      'islandora_cmodels' => array(
        'islandora:sp-audioCModel' => 'islandora:sp-audioCModel',
        'islandora:sp_videoCModel' => 'islandora:sp_videoCModel',
        'fedora-system:FedoraObject-3.0' => 0,
        'fedora-system:ServiceDefinition-3.0' => 0,
        'fedora-system:ContentModel-3.0' => 0,
        'fedora-system:ServiceDeployment-3.0' => 0,
        'islandora:bookCModel' => 0,
        'islandora:newspaperIssueCModel' => 0,
        'islandora:sp_pdf' => 0,
        'islandora:entityCModel' => 0,
        'islandora:newspaperCModel' => 0,
        'islandora:eventCModel' => 0,
        'islandora:placeCModel' => 0,
        'islandora:newspaperPageCModel' => 0,
        'islandora:sp_disk_image' => 0,
        'islandora:collectionCModel' => 0,
        'islandora:personCModel' => 0,
        'islandora:compoundCModel' => 0,
        'islandora:pageCModel' => 0,
        'islandora:sp_basic_image' => 0,
        'islandora:organizationCModel' => 0,
        'islandora:sp_web_archive' => 0,
        'islandora:sp_large_image_cmodel' => 0,
        'ir:citationCModel' => 0,
        'ir:thesisCModel' => 0,
        'islandora:WADMCModel' => 0,
        'islandora:WADMContainerCModel' => 0,
      ),
    ),
  ),
);
$context->reactions = array(
  'block' => array(
    'blocks' => array(
      'views-a39ac53385ec2465993d7b4c2353afc7' => array(
        'module' => 'views',
        'delta' => 'a39ac53385ec2465993d7b4c2353afc7',
        'region' => 'content',
        'weight' => '-10',
      ),
    ),
  ),
  'css_module' => array(
    'sites/all/modules/islandora_web_annotations' => array(
      'sites/all/modules/islandora_web_annotations/css/video/video.css' => 'sites/all/modules/islandora_web_annotations/css/video/video.css',
      'sites/all/modules/islandora_web_annotations/lib/css/video-js/video-js.css' => 'sites/all/modules/islandora_web_annotations/lib/css/video-js/video-js.css',
      'sites/all/modules/islandora_web_annotations/lib/css/richText-annotator.min.css' => 'sites/all/modules/islandora_web_annotations/lib/css/richText-annotator.min.css',
      'sites/all/modules/islandora_web_annotations/lib/css/annotator.min.css' => 'sites/all/modules/islandora_web_annotations/lib/css/annotator.min.css',
      'sites/all/modules/islandora_web_annotations/lib/css/rangeslider.min.css' => 'sites/all/modules/islandora_web_annotations/lib/css/rangeslider.min.css',
      'sites/all/modules/islandora_web_annotations/lib/css/ova.css' => 'sites/all/modules/islandora_web_annotations/lib/css/ova.css',
    ),
  ),
  'js_module' => array(
    'sites/all/modules/islandora_web_annotations' => array(
      'sites/all/modules/islandora_web_annotations/lib/js/tinymce/js/tinymce/tinymce.min.js' => 'sites/all/modules/islandora_web_annotations/lib/js/tinymce/js/tinymce/tinymce.min.js',
      'sites/all/modules/islandora_web_annotations/lib/js/annotator-full.min.js' => 'sites/all/modules/islandora_web_annotations/lib/js/annotator-full.min.js',
      'sites/all/modules/islandora_web_annotations/lib/js/jquery.blockUI.js' => 'sites/all/modules/islandora_web_annotations/lib/js/jquery.blockUI.js',
      'sites/all/modules/islandora_web_annotations/lib/js/richText-annotator.min.js' => 'sites/all/modules/islandora_web_annotations/lib/js/richText-annotator.min.js',
      'sites/all/modules/islandora_web_annotations/lib/js/rangeslider.min.js' => 'sites/all/modules/islandora_web_annotations/lib/js/rangeslider.min.js',
    ),
  ),
  'js_path' => array(
    'sites/all/modules/islandora_web_annotations/lib/js' => array(
      'sites/all/modules/islandora_web_annotations/lib/js/ova.js' => 'sites/all/modules/islandora_web_annotations/lib/js/ova.js',
    ),
    'sites/all/modules/islandora_web_annotations/js' => array(
      'sites/all/modules/islandora_web_annotations/js/video/video.js' => 'sites/all/modules/islandora_web_annotations/js/video/video.js',
    ),
  ),
);
$context->condition_mode = 0;
kimpham54 commented 6 years ago

context has been updated in documentation. when you create an annotation for a video object, you still have to click in the top left area but it's not as finicky. when you edit a video annotation, you don't have to click on the top left corner. fix is acceptable.