search

digitalutsc / islandora_web_annotations

An Islandora module that enables annotation on Islandora objects, following the W3C Web annotation model.
GNU General Public License v3.0
7 stars 5 forks source link

permissions is not respected for audio, video and oral histories #161

Closed kimpham54 closed 7 years ago

kimpham54 commented 7 years ago

Description CRUD permissions configured through admin/people/permissions are not being respected for audio, video and oral history content models. They are being respected for basic and large image content models.

Steps to reproduce Turn off all permissions for Islandora Web Annotations, or only enable view web annotations

Expected Behaviour You should not be able to create web annotations

Actual Behaviour You are still able to create web annotations in audio, video and oral history content models

Natkeeran commented 7 years ago

This PR partially addresses this issue: https://github.com/digitalutsc/islandora_web_annotations/commit/ecbf12268483684cf06a15749cb9bffdd5143b77

Still need to review if we need to check for user permissions in the controller. Else, scripts may be able to post to those endpoints.

kimpham54 commented 7 years ago

@Natkeeran https://github.com/digitalutsc/islandora_web_annotations/commit/ecbf12268483684cf06a15749cb9bffdd5143b77 was tested on video and works for all permission settings

MarcusBarnes commented 7 years ago

Initially addressed in pull-request https://github.com/digitalutsc/islandora_web_annotations/pull/166 (merged with commit https://github.com/digitalutsc/islandora_web_annotations/commit/f78ac04e815f7cbc65561a06b94ea3a8d05cae99).