search

digitalutsc / islandora_web_annotations

An Islandora module that enables annotation on Islandora objects, following the W3C Web annotation model.
GNU General Public License v3.0
7 stars 5 forks source link

simultaneous editing does not provide a conflict notice #165

Closed kimpham54 closed 7 years ago

kimpham54 commented 7 years ago

When two users try to edit the same annotation in a large image object, the user whose edits could be saved does not receive an error message.

Steps to Reproduce Assign two users to edit the same annotation in a large image object. Have two users add edits, then synchronize the saving of an annotation at the same time.

Expected behaviour For one user, the edits will be saved successfully. For the second user, a warning message would appear saying that there has been a conflict and edits could not be saved.

Ideally, there would be a locking mechanism that would prevent the second user from editing in the first place (and letting them know that someone else is currently editing the annotation).

Actual behaviour For the first user, edits are saved successfully. No message is thrown back at the second user, their edits are not saved.

kimpham54 commented 7 years ago

this is confirmed in Basic Image as well

MarcusBarnes commented 7 years ago

Addressed in pull-request https://github.com/digitalutsc/islandora_web_annotations/pull/172 (merged with https://github.com/digitalutsc/islandora_web_annotations/commit/8a1f91198a3d8ec8ca27cdb2a7ca507363cc92f1).