digitalutsc / islandora_web_annotations

An Islandora module that enables annotation on Islandora objects, following the W3C Web annotation model.

GNU General Public License v3.0

7 stars 5 forks source link

ensure that the conflict message is shown #172

Closed Natkeeran closed 7 years ago

Natkeeran commented 7 years ago

What does this Pull Request do?

This PR addresses this issue: https://github.com/digitalutsc/islandora_web_annotations/issues/165

This is an regression bug introduced during enabling of html block back. A property is being accessed when it is not defined, throwing a js error, thus the message does not get shown. Ensured that the message gets shown.

How should this be tested?

Get the PR and follow the steps in the issue. Ensure that the conflict message is shown.

MarcusBarnes commented 7 years ago

@kimpham54 @kstapelfeld Would you please test this pull-request? @Natkeeran and I have already tested but would like to make sure it works as expected for you. Please feel free to merge if it works as expected for you. Thank you in advance.