search

digitalutsc / islandora_web_annotations

An Islandora module that enables annotation on Islandora objects, following the W3C Web annotation model.
GNU General Public License v3.0
7 stars 5 forks source link

Display captions at the bottom rather than the top of the screen #183

Closed kstapelfeldt closed 6 years ago

kstapelfeldt commented 7 years ago

Typically, captions are expected to appear at the bottom rather than the top of the video.

Natkeeran commented 6 years ago

Removing the 'sites/all/modules/islandora_web_annotations/lib/css/video-js/video-js.css' => 'sites/all/modules/islandora_web_annotations/lib/css/video-js/video-js.css' from context definition seems to fix this issue. The default video-js.css from the islandora video-js module seems to work without issue. Needs further testing.
'

kimpham54 commented 6 years ago

needs to be documented prior to release

MarcusBarnes commented 6 years ago

For shorter cues, the suggestion of removing 'sites/all/modules/islandora_web_annotations/lib/css/video-js/video-js.css' => 'sites/all/modules/islandora_web_annotations/lib/css/video-js/video-js.css' from context definition appears to work. However, when there is a large amount of text in a given cue, the box containing the captions extends beyond the video block.

If a suitable solution is not available in short order, we can document this adjustment with the given caveat about long captions and continue to work on this for the next release.

kimpham54 commented 6 years ago

@MarcusBarnes documenting sounds fine. can you create a new issue referencing this one based on your observation?

MarcusBarnes commented 6 years ago

Documentation at https://github.com/digitalutsc/islandora_web_annotations/wiki/Video,-Audio,-Oral-History#making-adjustments-to-the-closed-captions-position

The new issue is at https://github.com/digitalutsc/islandora_web_annotations/issues/245