Natkeeran commented 7 years ago

What does this Pull Request do?

This PR addresses this issue: https://github.com/digitalutsc/islandora_web_annotations/issues/160

Able to load basic image and video js annotations created with or without pathauto, while having pathauto enabled or disabled
JsonLD for basic/large image annotations should store un-aliases value for context/target properties

How should this be tested?

Get the PR
Create annotations without pathauto for basic image
Enable pathauto
Verify that annotations can be loaded
Create another annotation
Verify that the json-ld context and target properties do not contain the alias path
Please repeat the above steps for large image and video.js

Notes:

when path auto is enabled, the annotations block do not show because the targeting won't be applied.

If everything goes well, please do squash merge.

MarcusBarnes commented 7 years ago

I've tested this and it appears to work as described. Awaiting further testing and review by another interested party before merging. Thank you for your patience.

kimpham54 commented 7 years ago

tested and works as indicated. thank you

digitalutsc / islandora_web_annotations

Issue 160 #189

What does this Pull Request do?

How should this be tested?