digitalutsc / islandora_web_annotations

An Islandora module that enables annotation on Islandora objects, following the W3C Web annotation model.
GNU General Public License v3.0
7 stars 5 forks source link

Adds datetime as xsd:dateTime with the UTC timezone expressed as Z. #195

Closed MarcusBarnes closed 7 years ago

MarcusBarnes commented 7 years ago

Adds datetime as xsd:dateTime with the UTC timezone expressed as Z. Addresses issue #191.

What does this Pull Request do?

Created and updated properties now use datetime value as a xsd:dateTime with the UTC timezone expressed as Z for basic and large image (as required by the Web Annotation Data Model). This was already handled properly for video and audio using the Open Video Annotation library (OVA).

What's new?

Uses UTC time with timezone expressed as Z as the value for created and updated properties.

How should this be tested?

After pulling the changes, turn on verbose messaging in the Web Annotation Utility configuration settings. Create and update annotations for the supported content models. The values of the created and updated properties should display datetimes adjusted to use Y-m-d\TH:i:s\Z (or Y-m-d\TH:i:s.v\Z for audio, video and oral histories) .

Additional Notes:

Note that milliseconds is optional. The OVA library uses milliseconds. We have chosen not to use milliseconds for created and updated for basic and large image unless the need arises. Doing otherwise will require some additional custom code, for example, something like that in this comment in the PHP docs. PHP 7 includes a new format parameter for milliseconds 'v', but this is not available in earlier versions of PHP.

Natkeeran commented 7 years ago

Adds the UTC date on create and update. Works as expected. Thank you.