digitalutsc / islandora_web_annotations

An Islandora module that enables annotation on Islandora objects, following the W3C Web annotation model.
GNU General Public License v3.0
7 stars 5 forks source link

Force selection of annotation namespace #225

Closed MarcusBarnes closed 6 years ago

MarcusBarnes commented 6 years ago

What does this Pull Request do?

Removes the default annotation namespace setting and makes filling this configuration setting required. See issue #220.

What's new?

Does not pre-fill the annotation namespace configuration setting and also makes this setting required. Updates the form language for this setting too.

How should this be tested?

Additional Notes:

@Natkeeran It would be good to check that we remove other Web Annotation variables that are saved to Drupal's variables table on module uninstall.

MarcusBarnes commented 6 years ago

Need to pull in the changes made in pull-request https://github.com/digitalutsc/islandora_web_annotations/pull/227 so that this pull-request will pass the Travis CI build. I'll close and re-open.