search

digitalutsc / islandora_web_annotations

An Islandora module that enables annotation on Islandora objects, following the W3C Web annotation model.
GNU General Public License v3.0
7 stars 5 forks source link

Review effects of recent PR to OpenSeaDragon library #231

Closed kstapelfeldt closed 6 years ago

kstapelfeldt commented 6 years ago

How does the merging of this code affect our annotation functions for large image. This issue must be resolved and then we need to review and test the remaining bugs to see if they are still relevant.

Natkeeran commented 6 years ago

This issue is related to open sea dragon viewer not being available in the latest version. Created a PR in the openseadragon module to address this issue: https://github.com/Islandora/islandora_openseadragon/pull/83

kstapelfeldt commented 6 years ago

Not as bad as we thought. Nat has created a pull request for Open Sea Dragon. Nat will create a JIRA ticket to go with the pull request, and is in communication with Diego about this. We are expecting it will be merged, but Nat will report back.

kstapelfeldt commented 6 years ago

Need to update documentation after pull request is merged

MarcusBarnes commented 6 years ago

@Natkeeran's pull-request against islandora_openseadragon was accepted and merged. The corresponding JIRA ticket was also closed.