search

digitalwithyou / craft-facebook-conversion

Craft CMS plugin to send web events directly to Facebook
https://digitalwithyou.com/en/plugins/facebook-conversion/getting-started
Other
0 stars 3 forks source link

ExternalId breaks the Facebook Pixel hook #11

Closed karensg closed 2 years ago

karensg commented 3 years ago

It is not escaped in JavaScript and throws an error. image

karensg commented 3 years ago

This only happens when the user is logged in btw

matt-adigital commented 2 years ago

We are also seeing this error. Browser console reports the following: Uncaught ReferenceError: $2y$13$aMdjMm7aN3wjY is not defined

Updating line 31 in hooks/HeadTag.php to have single quotes around {$externalId} fixes this so could it please be included in the next release @Diewy ? Thanks

Diewy commented 2 years ago

Fixed in v1.0.16