digitalwithyou / craft-facebook-conversion

Craft CMS plugin to send web events directly to Facebook
https://digitalwithyou.com/en/plugins/facebook-conversion/getting-started
Other
0 stars 3 forks source link

SDK should update to latest version. #27

Closed mostafasoufi closed 2 years ago

mostafasoufi commented 2 years ago

According to the reference (#9a7f6), there is an issue behind the reference, and the SDK should be updated to the latest commit.

https://github.com/facebook/facebook-php-business-sdk/commits/main

Diewy commented 2 years ago

Hi @mostafasoufi,

We're using the latest package version, currently v15. I see that I made a typo, v14 instead of v15, in the commit message (woops), but the composer.json file is changed correctly.

I don't think it would be a good idea to start using dev-main without any special reason.

mostafasoufi commented 2 years ago

Actually, It's not the dev-main and you still need to update the composer.lock 🙂

Screenshot 2022-10-31 at 6 00 33 PM

Diewy commented 2 years ago

Hi @mostafasoufi ,

I'm guessing you had the same issue as #29. Since Facebook didn't release a new version yet I temporarily updated the version to a specifc commit on the main branch which should fix the problem.