search

digitalyacht / ikommunicate

Introduction to Signal K with iKommunicate
38 stars 7 forks source link

Depth Below Keel shows "Meters" label when value is in Feet #4

Open gvaughan67 opened 6 years ago

gvaughan67 commented 6 years ago

When Feet units are selected for Depth, other Depth sentences work properly but Depth Below Keel does not. Value is shown in feet but is labeled Meters. All displayModes.

sumps commented 6 years ago

Please can you let me know what app you are using to display depth and confirm you are running the latest iKommunicate firmware?

gvaughan67 commented 6 years ago

I am sorry - Kindle app. I do not have an iKommunicate device.

sumps commented 6 years ago

The Kindle app was created as part of our Open Source iKommunicate SDK and we do not provide support for it, but encourage other developers to take the source code and re-develop it.

It is written in JavaScript and although I am not a developer, I think it should be fairly straight forward even for a non-developer to look through the code and find how to fix this bug.

gvaughan67 commented 6 years ago

No problem, this is not a request for support; the bugs I have noted are fixed, worked around or inapplicable in my installation, I have a lot to learn before I could undertake it myself, but I am glad you are open to someone fixing it up. By listing it on NPM it could be made available for installation directly in the SignalK server node.