search

digitarald / firewatch

Real-time command-line memory monitor for Firefox OS devices.
40 stars 11 forks source link

bring back showing at least the b2g system process by default #3

Closed asutherland closed 10 years ago

asutherland commented 10 years ago

firewatch's graphing server UI mode is super awesome for watching the memory impact of things without foolishly relying on discrete data-points. Thanks for this!

I noticed you disabled graphing the system b2g process. I think this is inadvisable since the b2g parent process may retain memory thanks to the actions of the content processes, so it should arguably be visible, even if you make its graph lines more subtle.

Specifically, things like memory-backed Blobs sent between processes end up retained in the system process, IndexedDB work happens in the main process, network goes through there, etc. For the email app I am testing sending large files and the impact we have on the system process is extremely notable. While random people may not be able to tell what is going on in the system process, knowing that something weird is happening there is likely invaluable to them.

I did flip the hideSystem boolean in getInitial state, so it was easy for me to fix locally, but I'd suggest changing it back more permanently and/or treating b2g as different from the nuwa process/etc.

digitarald commented 10 years ago

Great input on why b2g is important, we should start a FAQ. The next push will have the UI to switch hideSystem. I'll probably show it by default as otherwise the graph can be quiet empty.