search

digitarald / flash-b2g

Flash Firefox OS devices from public Mozilla builds.
MIT License
18 stars 5 forks source link

RangeError: Maximum call stack size exceeded #21

Closed nickdesaulniers closed 10 years ago

nickdesaulniers commented 10 years ago 
node index.js flame 2.0 -r
Connecting to ftp.mozilla.org

/Users/Nicholas/mozilla/flash-b2g/node_modules/jsftp/node_modules/parse-listing/src/parser.js:186
    var group = entry.match(RE_UnixEntry);
                      ^
RangeError: Maximum call stack size exceeded
digitarald commented 10 years ago

Related to https://github.com/sergi/jsftp/issues/91#issuecomment-56219034 , the code not using async.eachSeries in an async way.

digitarald commented 10 years ago

Pull request pending: https://github.com/sergi/parse-listing/pull/4

asutherland commented 10 years ago

This is now fixed if you update package.json to use jsftp 1.3.6 because that issue 91 was addressed/etc.

asutherland commented 10 years ago

Also, when I just used digitarald's fix, node freaked out like so:

(node) warning: Recursive process.nextTick detected. This will break in the next version of node. Please use setImmediate for recursive deferral.
nickdesaulniers commented 10 years ago

So it was fixed upstream, with a temporary fix?

asutherland commented 10 years ago

The fix looks permanent to me. https://github.com/sergi/parse-listing/commit/e5d0d2f7a1ce00d208f0cb13fe838a02e33ed0ab addressed the problem in parse-listing and jsftp took the upgraded version of it. All that needs to be done here is bump package.json for jsftp to 1.3.6.